set max listeners for event emitter #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ralphtheninja
approved these changes
Jun 29, 2019
|
This is a good practice! I think though that the issue is around an "update" event, so I think the culprit is probably here, where we have a listener inside of a listener: https://github.com/cabal-club/cabal-cli/blob/master/neat-screen.js#L237 |
cblgh
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
i was working on cabal client when i noticed the following
so i figured we would do the same thing in the hopes of it solving cabal-club/cabal-cli#110
tagging a few reviewers to make sure this isn't really dumb